Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): use a dev version of create-pull-request action to fix issue. #92

Merged
merged 1 commit into from Jan 31, 2023

Conversation

FedeDP
Copy link
Collaborator

@FedeDP FedeDP commented Jan 31, 2023

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area ci

What this PR does / why we need it:

Uses dev version of create-pull-request action to fix peter-evans/create-pull-request#1170

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@FedeDP
Copy link
Collaborator Author

FedeDP commented Jan 31, 2023

Wip because i moved update-kernels on pull request trigger to be able to quickly test it.

@FedeDP FedeDP force-pushed the fix/create_pr_update-kernels branch from 86eca26 to 7f307e9 Compare January 31, 2023 08:00
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP FedeDP force-pushed the fix/create_pr_update-kernels branch from 7f307e9 to 9872907 Compare January 31, 2023 10:07
@FedeDP FedeDP changed the title wip: fix(ci): use a dev version of create-pull-request action to fix issue. fix(ci): use a dev version of create-pull-request action to fix issue. Jan 31, 2023
@FedeDP
Copy link
Collaborator Author

FedeDP commented Jan 31, 2023

The PR was created! #93
😃
Removing wip.

@FedeDP
Copy link
Collaborator Author

FedeDP commented Jan 31, 2023

I still don't get why on #93 the CI job is not being triggered :/

EDIT: because of: peter-evans/create-pull-request#48 (comment)

@FedeDP
Copy link
Collaborator Author

FedeDP commented Jan 31, 2023

/hold

@FedeDP
Copy link
Collaborator Author

FedeDP commented Jan 31, 2023

/unhold

I will move the update-kernels workflow to the kernels branch in a subsequent PR; then, the test kernel-crawler job will be triggered by:

on:
  workflow_run:
    workflows: [update-kernels]
    types:
      - completed

And will then checkout the update/kernels branch to perform the jq validation step.

@poiana poiana added the lgtm label Jan 31, 2023
@poiana poiana merged commit d529e54 into main Jan 31, 2023
@poiana poiana deleted the fix/create_pr_update-kernels branch January 31, 2023 12:36
@FedeDP FedeDP restored the fix/create_pr_update-kernels branch October 23, 2023 13:42
@FedeDP FedeDP deleted the fix/create_pr_update-kernels branch October 23, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fatal: --local can only be used inside a git repository error on containers
3 participants