Skip to content

Commit

Permalink
fix: Fix grpcWeb import in hub-web (#2006)
Browse files Browse the repository at this point in the history
## Motivation

We accidentally lost the code that was fixing up bad protoc js file
generation for hub-web. Bring it back and fix compilation.

## Change Summary

Describe the changes being made in 1-2 concise sentences.

## Merge Checklist

_Choose all relevant options below by adding an `x` now or at any time
before submitting for review_

- [x] PR title adheres to the [conventional
commits](https://www.conventionalcommits.org/en/v1.0.0/) standard
- [x] PR has a
[changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets)
- [x] PR has been tagged with a change label(s) (i.e. documentation,
feature, bugfix, or chore)
- [ ] PR includes
[documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs)
if necessary.
- [x] All [commits have been
signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits)

## Additional Context

If this is a relatively large or complex change, provide more details
here that will help reviewers


<!-- start pr-codex -->

---

## PR-Codex overview
This PR updates the `hub-web` package to fix the `grpcWeb` import and
replaces `grpc` with `grpcWeb` in the codebase.

### Detailed summary
- Updated `hub-web` package to fix `grpcWeb` import
- Replaced `grpc` with `grpcWeb` in the codebase for consistency

> The following files were skipped due to too many changes:
`packages/hub-web/src/generated/rpc.ts`

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your
question}`

<!-- end pr-codex -->
  • Loading branch information
sanjayprabhu committed May 16, 2024
1 parent cdea6ca commit 920f6c0
Show file tree
Hide file tree
Showing 3 changed files with 109 additions and 104 deletions.
5 changes: 5 additions & 0 deletions .changeset/tame-flowers-fry.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@farcaster/hub-web": patch
---

fix: grpcWeb import
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"build": "./node_modules/.bin/turbo run build",
"clean": "./node_modules/.bin/turbo run clean",
"dev": "./node_modules/.bin/turbo run dev --parallel",
"protoc": "cd packages/core && yarn protoc && cd ../hub-nodejs && yarn protoc && cd ../hub-web && yarn protoc",
"protoc": "cd packages/core && yarn protoc && cd ../hub-nodejs && yarn protoc && cd ../hub-web && yarn protoc && sed -i '' 's/{ grpc }/grpcWeb/g; s/grpc\\./grpcWeb.grpc./g' src/generated/rpc.ts",
"test": "./node_modules/.bin/turbo run test",
"test:ci": "./node_modules/.bin/turbo run test:ci -- --passWithNoTests",
"lint": "./node_modules/.bin/turbo run lint --parallel",
Expand Down

0 comments on commit 920f6c0

Please sign in to comment.