Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add missing message type #2002

Merged
merged 1 commit into from
Jun 3, 2024
Merged

chore: Add missing message type #2002

merged 1 commit into from
Jun 3, 2024

Conversation

rcbgr
Copy link
Contributor

@rcbgr rcbgr commented May 15, 2024

Motivation

Describe why this issue should be fixed and link to any relevant design docs, issues or other relevant items.

Fix the OpenAPI spec

Change Summary

Describe the changes being made in 1-2 concise sentences.

Remove empty whitespaces and register the type on the message type. I generated a go client and before this fix, it would not compile.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

Additional Context

If this is a relatively large or complex change, provide more details here that will help reviewers


PR-Codex overview

This PR updates descriptions and schemas in the spec.yaml file for UserData and OnChainEvents.

Detailed summary

  • Updated descriptions for UserData and OnChainEvents
  • Adjusted response schemas based on parameters
  • Added clarity on optional parameters and response types

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented May 15, 2024

⚠️ No Changeset found

Latest commit: 8626639

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 8:00pm

@sds sds added the t-docs Add or update documentation label Jun 3, 2024
@sds sds changed the title Add missing message type chore: Add missing message type Jun 3, 2024
@sds sds enabled auto-merge (squash) June 3, 2024 17:10
@sds sds merged commit 7c24245 into farcasterxyz:main Jun 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-docs Add or update documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants