Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder fields in farm_log view #618

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from

Conversation

paul121
Copy link
Member

@paul121 paul121 commented Dec 8, 2022

This reorders the fields in the farm_log table view as described in this forum post: https://farmos.discourse.group/t/change-column-order-in-logs-view/1419?u=paul121

Before: status, ID, timestamp, log name, log type**
After: log name, log type**, timestamp, status, ID (moved to very last)
**the log type column is only displayed on the /logs page, not /logs/{log_type]

Unfortunately because this PR only changes the field order, this is blocked by this issue: https://www.drupal.org/project/farm/issues/3325911

I would like to consider removing the log ID from these table views, but I think we do need the log ID in the CSV export. We could override the CSV export to include the log ID but then then we lose the convenience of the "default views fields" in the CSV export display. If we did make this change for the log ID then this PR would not be blocked by the above issue.

What do we think?

@mstenta
Copy link
Member

mstenta commented Dec 8, 2022

I'll try to add thoughts to the forum topic so we don't split the conversation too much, but one question:

If we did make this change for the log ID then this PR would not be blocked by the above issue.

Not sure I understand, aren't all of these changes related to moving the columns around, not just the log ID?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants