Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAI-11182: Jira source when project list is supplied only fetch those #1458

Merged
merged 2 commits into from
May 14, 2024

Conversation

chalenge
Copy link
Contributor

Description

  • Optimize calls to only fetch the listed projects

Type of change

  • Bug fix
  • New feature
  • Breaking change

Signed-off-by: Chalenge Masekera <5385518+chalenge@users.noreply.github.com>
Copy link

sonarcloud bot commented May 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@@ -184,6 +184,7 @@ export class Jira {
'X-Force-Accept-Language': true,
},
timeout: cfg.timeout ?? DEFAULT_TIMEOUT,
paramsSerializer: {indexes: null},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this config added for making keys param work in searchProjects?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the default behaviour results in incorrect query params. See axios/axios#5058 (comment)

Copy link
Contributor

@matiaslcoulougian matiaslcoulougian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@chalenge chalenge merged commit 2a9f2f2 into main May 14, 2024
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2024
@chalenge chalenge deleted the chale/fetch-listed-projects branch May 14, 2024 16:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants