Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Ahmed,
great package! Thanks for publishing this nifty generator.
I'm using this package in a typescript 3.0 project with
--build
mode and have run into this issue, caused by the presence of.ts
files (even in anode_modules/
directory!) outside the scope of theinclude
-d files in thetsconfig.json
.Luckily, this package was the only dependency in my project that published a
.ts
file, so for me the quickest workaround was to re-publish this module to npm with a whitelist so only compiled artifacts (including the.js
files) are bundled. Sure enough, that got me past the bug and my project builds again.I also took this opportunity to bump the typescript version so
.map
files can be published, providing additionaljump-to
features in IDEs; and to ignore all compiled artifacts from the git repository.I'm not versed with webpack so I hope I didn't adversely affect anything there, but all of the original tests are still passing so I'm opening this pull-request to avoid hoarding changes downstream.
Thanks again for your work, I found it very helpful!
Happy hacking,
Eric