Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use publishing whitelist #2

Merged
merged 2 commits into from Apr 27, 2019

Conversation

EricCrosson
Copy link
Contributor

Hi Ahmed,

great package! Thanks for publishing this nifty generator.

I'm using this package in a typescript 3.0 project with --build mode and have run into this issue, caused by the presence of .ts files (even in a node_modules/ directory!) outside the scope of the include-d files in the tsconfig.json.

Luckily, this package was the only dependency in my project that published a .ts file, so for me the quickest workaround was to re-publish this module to npm with a whitelist so only compiled artifacts (including the .js files) are bundled. Sure enough, that got me past the bug and my project builds again.

I also took this opportunity to bump the typescript version so .map files can be published, providing additional jump-to features in IDEs; and to ignore all compiled artifacts from the git repository.

I'm not versed with webpack so I hope I didn't adversely affect anything there, but all of the original tests are still passing so I'm opening this pull-request to avoid hoarding changes downstream.

Thanks again for your work, I found it very helpful!
Happy hacking,
Eric

@fasiha fasiha merged commit 4abd22f into fasiha:master Apr 27, 2019
@fasiha
Copy link
Owner

fasiha commented Apr 27, 2019

Thank you for your hard work!!! I'll use this as the model to publish future TypeScript code!

@EricCrosson EricCrosson deleted the use-publishing-whitelist branch April 27, 2019 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants