JsonConfig: Added brightness
properties and dim_
colors
#910
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was making a custom config in VScode and noticed issues with Intellisense.
First, most of the properties for the
brightness
module weren't valid according to the template.Second, when using colors, I noticed that
bright_
colors are returning the same color as the base ones. I then tried with thedim_
prefix which did give me the other shades which were the darker ones. I got this behavior on both Fedora 40 GNOME 46 and Ubuntu 22.04 GNOME 42.9. I am not sure if the issue is GNOME or Linux-specific which is why I only addeddim_
variants to the color list instead of replacing thebright_
ones.