Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsonConfig: Added brightness properties and dim_ colors #910

Merged
merged 2 commits into from
May 10, 2024

Conversation

djinnalexio
Copy link
Contributor

I was making a custom config in VScode and noticed issues with Intellisense.

First, most of the properties for the brightness module weren't valid according to the template.

Second, when using colors, I noticed that bright_ colors are returning the same color as the base ones. I then tried with the dim_ prefix which did give me the other shades which were the darker ones. I got this behavior on both Fedora 40 GNOME 46 and Ubuntu 22.04 GNOME 42.9. I am not sure if the issue is GNOME or Linux-specific which is why I only added dim_ variants to the color list instead of replacing the bright_ ones.

@CarterLi
Copy link
Member

dim_ bright_ are meant to be used by combining standard color keywords. Adding all the combinations will make the list too verbose.

In addition, 256 color and true color can also be specified. See fastfetch -h color for detail. JSON schema is main for suggestion purpose, not validation.

I noticed that bright_ colors are returning the same color as the base ones.

Some colors (like keys) are already in bright mode. Try --bright-color false

@CarterLi CarterLi merged commit ce6b595 into fastfetch-cli:dev May 10, 2024
@djinnalexio
Copy link
Contributor Author

In addition, 256 color and true color can also be specified. See fastfetch -h color for detail. JSON schema is main for suggestion purpose, not validation.

I get how it works now, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants