Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for Fastify v5 #150

Merged
merged 3 commits into from Mar 22, 2024
Merged

Update for Fastify v5 #150

merged 3 commits into from Mar 22, 2024

Conversation

synapse
Copy link

@synapse synapse commented Mar 22, 2024 •
edited

Ref: fastify/fastify#5116

⚠️ There's already a next branch here

Checklist

CC @simoneb

simoneb
simoneb reviewed Mar 22, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
simoneb
simoneb reviewed Mar 22, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
simoneb
simoneb reviewed Mar 22, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
simoneb
simoneb reviewed Mar 22, 2024
View reviewed changes
test/decode-text.test.js Outdated Show resolved Hide resolved
synapse
synapse commented Mar 22, 2024
View reviewed changes
Copy link
Author

@synapse synapse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed typo

@synapse synapse changed the base branch from next to master March 22, 2024 10:18
synapse
synapse commented Mar 22, 2024
View reviewed changes
Copy link
Author

@synapse synapse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed engine field

@gurgunday gurgunday changed the base branch from master to next March 22, 2024 10:36
gurgunday
gurgunday approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gurgunday gurgunday merged commit fa20420 into fastify:next Mar 22, 2024
15 checks passed
@synapse synapse mentioned this pull request Mar 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simoneb simoneb simoneb left review comments

@gurgunday gurgunday gurgunday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
v5 Work
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@synapse @simoneb @gurgunday