Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update docs and ci #82

Merged
merged 8 commits into from Mar 1, 2021
Merged

chore: update docs and ci #82

merged 8 commits into from Mar 1, 2021

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Feb 11, 2021 •
edited

Checklist

zekth
zekth approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@zekth zekth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mcollina
mcollina requested changes Mar 1, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, just a nit

auth.js Outdated Show resolved Hide resolved
jsumners
jsumners reviewed Mar 1, 2021
View reviewed changes
auth.js Outdated Show resolved Hide resolved
@Fdawgs @jsumners
chore(auth): stop standardjs linting for loop
a4946a7 
Co-authored-by: James Sumners <james@sumners.email>
jsumners
jsumners approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fdawgs Fdawgs requested a review from mcollina March 1, 2021 13:28
@mcollina mcollina merged commit 85af45c into fastify:master Mar 1, 2021
@Fdawgs Fdawgs deleted the chore/docs-ci branch March 2, 2021 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsumners jsumners jsumners approved these changes

@zekth zekth zekth approved these changes

@mcollina mcollina Awaiting requested review from mcollina

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Fdawgs @mcollina @jsumners @zekth