feat: add partitioned #261

gurgunday · 2023-11-08T19:54:44Z

Adds support for the non-standard Partitioned option

It was added to jshttp/cookie a few days ago

jsumners

I am against adding things that do not conform to the spec.

Uzlopak · 2023-11-08T20:16:13Z

We have to add it.

gurgunday · 2023-11-08T20:16:15Z

I am against adding things that do not conform to the spec.

I fully agree personally 😄

One of the reasons @mcollina forked cookie was to add this though

Users seem to want it

jsumners · 2023-11-08T23:01:35Z

We have to add it.

Why? Is it at least defined in a draft?

climba03003 · 2023-11-09T06:26:58Z

After some investigation,

Why?

Chrome started to ban / phase out third-party cookies. It can only be used with the new Partitioned attribute.
https://developer.chrome.com/docs/privacy-sandbox/third-party-cookie-phase-out/

Is it at least defined in a draft?

The Partitioned attribute is promoted by an individual draft.
Github: https://github.com/privacycg/CHIPS
DataTracker: https://datatracker.ietf.org/doc/html/draft-cutler-httpbis-partitioned-cookies#section-2.1

For my personal opinion, it seems only Google have the interest on this individual draft.
~~Neither Mozilla nor Apple Webkit is going to implement it in foreseeable future.~~
Mozilla and Apple Webkit are positive to the proposal, but still requesting some improvement or discussion before implementing the feature. We do not have a solid road map on when it would be implemented.
mozilla/standards-positions#678
WebKit/standards-positions#50

If we need to provide this option, I would mark it as Experimental because we don't know if it going to be a real standard (based on the Browser vendor interest.).

Edit(2023-11-15): update the Mozilla and Webkit position on the proposal.

Eomm

I would write in the reademe [experimental] with a reference to the @climba03003 's comment 🔝

cookie.js

Co-authored-by: James Sumners <321201+jsumners@users.noreply.github.com>

mcollina

lgtm

marco-ippolito · 2023-11-10T08:44:26Z

not blocking, but I strongly think it should be marked as experimental

gurgunday · 2023-11-10T10:28:57Z

Agreed, will do that

README.md

gurgunday · 2023-11-12T01:45:07Z

Well, now I want to change parseOptions to serializationOptions because it actually seems to do nothing to change parsing behavior

This reverts commit ad49da2.

Uzlopak

RSLGTM

README.md

Co-authored-by: Manuel Spigolon <behemoth89@gmail.com>

Fdawgs · 2023-11-14T17:37:51Z

Neither Mozilla nor Apple Webkit is going to implement it in foreseeable future.

They support the effort though:

gurgunday · 2023-11-14T18:30:07Z

Oh that's useful 🙏

climba03003 · 2023-11-15T03:48:22Z

They support the effort though

Good to know that, I have updated my comment to reflect the vendor interest.

fox1t · 2023-11-15T09:52:00Z

LGTM

gurgunday · 2023-11-15T10:23:21Z

Let me add a mention to @climba03003's comment, which sums it up nicely

[![Mend Renovate logo banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@fastify/cookie](https://togithub.com/fastify/fastify-cookie) | [`9.0.4` -> `9.2.0`](https://renovatebot.com/diffs/npm/@fastify%2fcookie/9.0.4/9.2.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@fastify%2fcookie/9.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@fastify%2fcookie/9.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@fastify%2fcookie/9.0.4/9.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@fastify%2fcookie/9.0.4/9.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify-cookie (@fastify/cookie)</summary> ### [`v9.2.0`](https://togithub.com/fastify/fastify-cookie/releases/tag/v9.2.0) [Compare Source](https://togithub.com/fastify/fastify-cookie/compare/v9.1.0...v9.2.0) #### What's Changed - chore: add `.gitattributes` file by [@Fdawgs](https://togithub.com/Fdawgs) in [fastify/fastify-cookie#255 - refactor(signer): add `u` unicode flag to regex by [@Fdawgs](https://togithub.com/Fdawgs) in [fastify/fastify-cookie#256 - chore(deps-dev): bump sinon from 16.1.3 to 17.0.0 by [@dependabot](https://togithub.com/dependabot) in [fastify/fastify-cookie#257 - chore(package): explicitly declare js module type by [@Fdawgs](https://togithub.com/Fdawgs) in [fastify/fastify-cookie#258 - refactor(plugin): replace `typeof` undefined check by [@Fdawgs](https://togithub.com/Fdawgs) in [fastify/fastify-cookie#259 - Go back to use our own cookie implementation by [@mcollina](https://togithub.com/mcollina) in [fastify/fastify-cookie#260 - feat: add partitioned by [@gurgunday](https://togithub.com/gurgunday) in [fastify/fastify-cookie#261 **Full Changelog**: fastify/fastify-cookie@v9.1.0...v9.2.0 ### [`v9.1.0`](https://togithub.com/fastify/fastify-cookie/releases/tag/v9.1.0) [Compare Source](https://togithub.com/fastify/fastify-cookie/compare/v9.0.4...v9.1.0) #### What's Changed - perf: don't initialize req.cookies before checking the header by [@gurgunday](https://togithub.com/gurgunday) in [fastify/fastify-cookie#248 - chore(deps-dev): bump tsd from 0.28.1 to 0.29.0 by [@dependabot](https://togithub.com/dependabot) in [fastify/fastify-cookie#249 - perf: use `node:` prefix for builtins by [@gurgunday](https://togithub.com/gurgunday) in [fastify/fastify-cookie#250 - chore(deps-dev): bump sinon from 15.2.0 to 16.0.0 by [@dependabot](https://togithub.com/dependabot) in [fastify/fastify-cookie#252 - use named exports by [@gurgunday](https://togithub.com/gurgunday) in [fastify/fastify-cookie#254 **Full Changelog**: fastify/fastify-cookie@v9.0.4...v9.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 4pm every weekday" in timezone Europe/Paris, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/specfy/specfy).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

gurgunday added 2 commits November 8, 2023 20:51

add partioned

0d14fb8

add more test

c761c84

gurgunday requested a review from a team November 8, 2023 19:54

jsumners reviewed Nov 8, 2023

View reviewed changes

Eomm reviewed Nov 9, 2023

View reviewed changes

cookie.js Show resolved Hide resolved

jsumners reviewed Nov 9, 2023

View reviewed changes

cookie.js Show resolved Hide resolved

Update cookie.js

17c7230

Co-authored-by: James Sumners <321201+jsumners@users.noreply.github.com>

mcollina approved these changes Nov 10, 2023

View reviewed changes

add readme

4d1ee36

jsumners reviewed Nov 11, 2023

View reviewed changes

README.md Outdated Show resolved Hide resolved

gurgunday added 2 commits November 12, 2023 02:40

import readme

b903611

add exp

ad49da2

gurgunday requested a review from a team November 12, 2023 01:45

Revert "add exp"

407a5b1

This reverts commit ad49da2.

Uzlopak approved these changes Nov 12, 2023

View reviewed changes

Eomm reviewed Nov 12, 2023

View reviewed changes

README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

gurgunday and others added 2 commits November 12, 2023 14:37

Warning

98f5fd1

Co-authored-by: Manuel Spigolon <behemoth89@gmail.com>

add links

b8d00f1

jsumners approved these changes Nov 12, 2023

View reviewed changes

link comment

385831f

mcollina merged commit 9e4652f into fastify:master Nov 15, 2023
19 checks passed

gurgunday deleted the add-part branch November 15, 2023 16:43

climba03003 mentioned this pull request Nov 23, 2023

Support Private Network CORS fastify/fastify-cors#277

Open

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add partitioned #261

feat: add partitioned #261

gurgunday commented Nov 8, 2023 •

edited

jsumners left a comment

Uzlopak commented Nov 8, 2023

gurgunday commented Nov 8, 2023 •

edited

jsumners commented Nov 8, 2023

climba03003 commented Nov 9, 2023 •

edited

Eomm left a comment

mcollina left a comment

marco-ippolito commented Nov 10, 2023

gurgunday commented Nov 10, 2023

gurgunday commented Nov 12, 2023

Uzlopak left a comment

Fdawgs commented Nov 14, 2023

gurgunday commented Nov 14, 2023

climba03003 commented Nov 15, 2023

fox1t commented Nov 15, 2023

gurgunday commented Nov 15, 2023

feat: add partitioned #261

feat: add partitioned #261

Conversation

gurgunday commented Nov 8, 2023 • edited

jsumners left a comment

Choose a reason for hiding this comment

Uzlopak commented Nov 8, 2023

gurgunday commented Nov 8, 2023 • edited

jsumners commented Nov 8, 2023

climba03003 commented Nov 9, 2023 • edited

Eomm left a comment

Choose a reason for hiding this comment

mcollina left a comment

Choose a reason for hiding this comment

marco-ippolito commented Nov 10, 2023

gurgunday commented Nov 10, 2023

gurgunday commented Nov 12, 2023

Uzlopak left a comment

Choose a reason for hiding this comment

Fdawgs commented Nov 14, 2023

gurgunday commented Nov 14, 2023

climba03003 commented Nov 15, 2023

fox1t commented Nov 15, 2023

gurgunday commented Nov 15, 2023

gurgunday commented Nov 8, 2023 •

edited

gurgunday commented Nov 8, 2023 •

edited

climba03003 commented Nov 9, 2023 •

edited