update for Fastify v5 #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fdawgs
reviewed
Jan 24, 2024
| @@ -17,7 +17,7 @@ on: | |||
|
|
|||
| jobs: | |||
| test: | |||
| uses: fastify/workflows/.github/workflows/plugins-ci.yml@v3 | |||
| uses: fastify/workflows/.github/workflows/plugins-ci.yml@v4.0.0 | |||
There was a problem hiding this comment.
Suggested change
| uses: fastify/workflows/.github/workflows/plugins-ci.yml@v4.0.0 | |
| uses: fastify/workflows/.github/workflows/plugins-ci.yml@v4 |
If you use v4 then it'll automatically pick up the latest, i.e. if we release 4.0.1 then it'll use that.
There was a problem hiding this comment.
Thanks, will do that
But then I'm not understanding something
Why didn't this work with rate-limit? Using v4 there with the redis workflow resulted in errors
fastify/fastify-rate-limit#350
https://github.com/fastify/fastify-rate-limit/actions/runs/7195862716
There was a problem hiding this comment.
There you go, it didn't work...
I think it might be because v4 doesn't exist as a release/tag — there is only v4.0.0
There was a problem hiding this comment.
Ah yeah, forgot the v4 release went awry: fastify/workflows#107, grumble grumble grumble.
Co-authored-by: Frazer Smith <frazer.dev@outlook.com> Signed-off-by: Gürgün Dayıoğlu <gurgun.dayioglu@icloud.com>
This reverts commit b7a3800.
Fdawgs
reviewed
Jan 24, 2024
This reverts commit c691788.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: fastify/fastify#5116
Checklist
npm run testandnpm run benchmarkand the Code of conduct