build(dependabot): ignore tap major updates #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fastify/plugins can run a mass update of tap and dependabot for all repos, which will save someone from having to do it manually as part of the v5 work. wdyt? |
|
Is the answer from openjs or what it was regarding the use of tap as dev depency negative? |
|
I would not hold my breath waiting on a licensing decision. It's going to take probably as long to get it as it will to prepare v5. |
jsumners
approved these changes
Nov 1, 2023
|
the license has not been approved yet afaik, similar problem with npm in node |
Eomm
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
I told to dependabot to ignore the dep by commenting the PRs in many repos TBH
PS: the pinned version does not have the new licence:
https://www.npmjs.com/package/tap/v/16.3.9
renovate bot
added a commit
to tomacheese/telcheck
that referenced
this pull request
Dec 4, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@fastify/cors](https://togithub.com/fastify/fastify-cors) | [`8.4.1` -> `8.4.2`](https://renovatebot.com/diffs/npm/@fastify%2fcors/8.4.1/8.4.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify-cors (@​fastify/cors)</summary> ### [`v8.4.2`](https://togithub.com/fastify/fastify-cors/releases/tag/v8.4.2) [Compare Source](https://togithub.com/fastify/fastify-cors/compare/v8.4.1...v8.4.2) #### What's Changed - build(dependabot): ignore tap major updates by [@​Fdawgs](https://togithub.com/Fdawgs) in [fastify/fastify-cors#276 - fix: support for embedded cors for route params by [@​mohammedSlimani](https://togithub.com/mohammedSlimani) in [fastify/fastify-cors#278 #### New Contributors - [@​mohammedSlimani](https://togithub.com/mohammedSlimani) made their first contribution in [fastify/fastify-cors#278 **Full Changelog**: fastify/fastify-cors@v8.4.1...v8.4.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/tomacheese/telcheck). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44MS4zIiwidXBkYXRlZEluVmVyIjoiMzcuODEuMyIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example mass update PR for fastify/fastify#5116
Checklist
npm run testandnpm run benchmarkand the Code of conduct