fix: express mutated request.url #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #11 Signed-off-by: Jamie King <jamie.king@aexp.com>
gurgunday
reviewed
Apr 15, 2024
Comment on lines
+605
to
+607
| fastify.addHook('onSend', (req, reply, payload, next) => { | ||
| t.ok('called') | ||
| next(null, payload) |
There was a problem hiding this comment.
Maybe this was a bug? Do we have the original idea behind this functionality saved somewhere?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11
I tried @Eomm's suggestion, but in this case next is never called, so it does not resolve the issue.
However, this solution does cause onSend to be called where it was not before. Would you consider this a breaking change or is it alright?
Checklist
npm run testandnpm run benchmarkand the Code of conduct