Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add decoratorName in the request object instead of default user #241

Merged
merged 2 commits into from
Jul 7, 2022
Merged

Add decoratorName in the request object instead of default user #241

merged 2 commits into from
Jul 7, 2022

Conversation

cberescu
Copy link
Contributor

@cberescu cberescu commented Jul 6, 2022

Replaced a line missed in pull #229 , where the old request.user was still used, with the new decoratorName variable

Checklist

@cberescu cberescu mentioned this pull request Jul 6, 2022
Closed
2 tasks
Eomm
Eomm reviewed Jul 6, 2022
View reviewed changes
Copy link
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test for this bug?

@cberescu
Copy link
Contributor Author

cberescu commented Jul 6, 2022

@Eomm I have added the test

mcollina
mcollina approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eomm Eomm merged commit cf38f48 into fastify:master Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@Eomm Eomm Eomm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cberescu @mcollina @Eomm @lordnimrod