Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add decoratorName to the types #248

Merged
merged 1 commit into from
Jul 14, 2022
Merged

chore: add decoratorName to the types #248

merged 1 commit into from
Jul 14, 2022

Conversation

salmanm
Copy link
Member

@salmanm salmanm commented Jul 13, 2022

Support for custom decoratorName was added in https://github.com/fastify/fastify-jwt/releases/tag/v6.2.1 but was missing from types. This PR fixes that

Checklist

mcollina
mcollina requested changes Jul 13, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a PR! Can you please add a unit test?
Thanks for opening a PR! Can you please add a unit test?

@salmanm salmanm marked this pull request as draft July 13, 2022 14:26
mcollina
mcollina approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@salmanm
Copy link
Member Author

salmanm commented Jul 13, 2022

@mcollina How do I make sure request instance here is decorated with decoratorName and not user?

@mcollina
Copy link
Member

not sure

@salmanm salmanm marked this pull request as ready for review July 13, 2022 15:05
mcollina
mcollina approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit e21fd13 into fastify:master Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@salmanm @mcollina