Add FormData decorator to request #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matteo Collina <hello@matteocollina.com>
gurgunday
reviewed
Apr 30, 2024
gurgunday
reviewed
May 1, 2024
gurgunday
reviewed
May 1, 2024
|
@gurgunday do you know why linting is failing, it's passing locally. |
|
Seems like a dependency conflict
fastify-multipart/package.json Line 28 in 7d6e124 And standard requires 16 normally... Running the following will solve it: npm i eslint-plugin-n@16 |
|
I actually can't see why they were installed separately in this repo |
|
Pulling from master should fix it |
Co-authored-by: Gürgün Dayıoğlu <hey@gurgun.day> Signed-off-by: Matteo Collina <matteo.collina@gmail.com>
kibertoad
reviewed
May 2, 2024
kibertoad
reviewed
May 2, 2024
Signed-off-by: Matteo Collina <hello@matteocollina.com>
|
@kibertoad fixed |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
gurgunday
reviewed
May 6, 2024
gurgunday
reviewed
May 6, 2024
|
@gurgunday may I get a final review? |
kibertoad
approved these changes
May 7, 2024
4 tasks
gurgunday
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a tiny helper to create a
FormDataobject for compatibility with Web Standards.