Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use reusable workflow #143

Merged
merged 4 commits into from
Aug 17, 2022
Merged

use reusable workflow #143

merged 4 commits into from
Aug 17, 2022

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Aug 12, 2022

Checklist

@Uzlopak Uzlopak requested a review from Fdawgs August 12, 2022 09:32
@Fdawgs
Copy link
Member

Fdawgs commented Aug 16, 2022

Will review the Postgres shared workflow tomorrow

@Fdawgs Fdawgs self-assigned this Aug 17, 2022
@Fdawgs
Copy link
Member

Fdawgs commented Aug 17, 2022

The shared workflow and the existing workflow in this repo are identical apart from npm i disallowing scripts in the shared workflow. Can't think of anything else that could cause it to continue to fail. :/

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Aug 17, 2022

my assumption: ignore scripts is denying npm i to install the node-bindings for postgres

@Fdawgs Fdawgs merged commit da0e777 into master Aug 17, 2022
@Fdawgs Fdawgs deleted the reusable-workflow branch August 17, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants