Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow the user choose the namespace of the redis #249

Merged
merged 6 commits into from
Jul 18, 2022
Merged

allow the user choose the namespace of the redis #249

merged 6 commits into from
Jul 18, 2022

Conversation

DiogoMarques2003
Copy link
Contributor

@DiogoMarques2003 DiogoMarques2003 commented Jul 15, 2022

Checklist

package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "@fastify/rate-limit",
"version": "7.1.0",
"version": "7.1.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this, we'll bump when releasing.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a PR! Can you please add a unit test?

@DiogoMarques2003
Copy link
Contributor Author

DiogoMarques2003 commented Jul 16, 2022

Thanks for opening a PR! Can you please add a unit test?

Unit teste for what ?
I don't think it is necessary to add any more unit tests since it was only added an optional parameter in the options

@Eomm
Copy link
Member

Eomm commented Jul 16, 2022

Unit teste for what ?

That the redis key is what you expext

I don't think it is necessary to add any more unit tests since it was only added an optional parameter in the options

In this way, we can't assure that this feature will be removed in future.

@DiogoMarques2003
Copy link
Contributor Author

@Eomm is this ? Can you check pls

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 2f9d0fa into fastify:master Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants