Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defaultStoreValues() is sent the request #157

Merged
merged 3 commits into from
Jun 11, 2023

Conversation

voxpelli
Copy link
Contributor

This PR fixes #156 by adding the current request instance as a parameter to the defaultStoreValues() factory

Checklist

Fixes fastify#156

Signed-off-by: Pelle Wessman <pelle@kodfabrik.se>
index.js Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link
Member

@kibertoad kibertoad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test is missing

@voxpelli
Copy link
Contributor Author

Test is missing

One question on this: In which of the three test files should tests preferably be added?

There seems to be e2e tests that's run in both jest and tap? + non-e2e tests in jest?

@kibertoad
Copy link
Member

@voxpelli e2e is preferable

@voxpelli
Copy link
Contributor Author

@kibertoad Should it be added in both the jest and tap ones then? I see that tap tests were added in #50 since jest tests were failing, now they all pass for me locally at least

@kibertoad
Copy link
Member

@voxpelli yeah, jest problem was fixed later. either of them or both would be good, I would err on the side of more jest tests

@voxpelli
Copy link
Contributor Author

@kibertoad Tests added

@voxpelli voxpelli requested a review from kibertoad June 10, 2023 23:03
@kibertoad kibertoad merged commit cc48c47 into fastify:master Jun 11, 2023
15 checks passed
@kibertoad
Copy link
Member

Thank you!

@voxpelli voxpelli deleted the voxpelli/issue156 branch June 11, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable default context items derived from request
2 participants