Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to Fastify v4, dropped error handler #109

Merged
merged 1 commit into from
May 12, 2022
Merged

Conversation

mcollina
Copy link
Member

Signed-off-by: Matteo Collina hello@matteocollina.com

This PR updates to Fastify v4 and drops the custom error handler support.
I do not think that's needed with Fastify v4 by default as that's now way simpler to manage.

Checklist

Signed-off-by: Matteo Collina <hello@matteocollina.com>
README.md Show resolved Hide resolved
@mcollina mcollina merged commit 73bf0a1 into master May 12, 2022
@mcollina mcollina deleted the update-to-fastify-v4 branch May 12, 2022 21:53
@hsynlms
Copy link
Contributor

hsynlms commented May 12, 2022

May I ask for the details of dropping the custom error handler?
I wonder what Fastify v4 gives us different than v3 to achieve the same motivation.

The motivation was:

This plugins also adds a custom error handler, which hides the error message in case of 500 errors that are being generated by throwed errors, instead it returns Something went wrong.

@hsynlms
Copy link
Contributor

hsynlms commented May 24, 2022

@mcollina details?

@mcollina
Copy link
Member Author

Check out fastify/fastify#3261

wd-David pushed a commit to wd-David/fastify-esbuild that referenced this pull request Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants