Skip to content

Commit

Permalink
Drop @typescript-eslint/no-misused-promises (#3741)
Browse files Browse the repository at this point in the history
* Drop @typescript-eslint/no-misused-promises

* ??

* updated steps

* moar fixes
  • Loading branch information
mcollina committed Mar 3, 2022
1 parent b2ce3d5 commit 77841ea
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 8 deletions.
15 changes: 8 additions & 7 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
paths-ignore:
- 'docs/**'
- '*.md'
pull_request_target:
pull_request:
paths-ignore:
- 'docs/**'
- '*.md'
Expand All @@ -14,10 +14,10 @@ jobs:
linter:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3

- name: Use Node.js
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: 'lts/*'

Expand All @@ -27,6 +27,7 @@ jobs:
- name: Lint code
run: |
echo 'this is an update'
npm run lint
coverage-nix:
Expand All @@ -44,10 +45,10 @@ jobs:
os: [macos-latest, ubuntu-latest, windows-latest]

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3

- name: Use Node.js
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}

Expand Down Expand Up @@ -87,9 +88,9 @@ jobs:
needs: test
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Use Node.js
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: 'lts/*'
- uses: actions/cache@v2
Expand Down
4 changes: 3 additions & 1 deletion types/.eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,9 @@
"@typescript-eslint/explicit-function-return-type": "off",
"@typescript-eslint/no-unused-vars": "off",
"@typescript-eslint/no-non-null-assertion": "off",
"@typescript-eslint/no-misused-promises": ["error"]
"@typescript-eslint/no-misused-promises": ["error", {
"checksVoidReturn": false
}]
},
"globals": {
"NodeJS": "readonly"
Expand Down

0 comments on commit 77841ea

Please sign in to comment.