fix: remove server.unref from tests (#3790) (#3815)

fastify · Apr 3, 2022 · a4b21f0 · a4b21f0
1 parent 15d9955
commit a4b21f0
Show file tree

Hide file tree

Showing 32 changed files with 105 additions and 96 deletions.
diff --git a/test/async-await.test.js b/test/async-await.test.js
@@ -48,7 +48,7 @@ test('async await', t => {
 
   fastify.listen({ port: 0 }, err => {
     t.error(err)
-    fastify.server.unref()
+    t.teardown(() => { fastify.close() })
 
     sget({
       method: 'GET',
@@ -410,7 +410,7 @@ test('promise was fulfilled with undefined', t => {
 
   fastify.listen({ port: 0 }, (err) => {
     t.error(err)
-    fastify.server.unref()
+    t.teardown(() => { fastify.close() })
 
     sget({
       method: 'GET',
@@ -452,7 +452,7 @@ test('error is not logged because promise was fulfilled with undefined but respo
 
   fastify.listen({ port: 0 }, (err) => {
     t.error(err)
-    fastify.server.unref()
+    t.teardown(() => { fastify.close() })
 
     sget({
       method: 'GET',

diff --git a/test/bodyLimit.test.js b/test/bodyLimit.test.js
@@ -30,7 +30,7 @@ test('bodyLimit', t => {
 
   fastify.listen({ port: 0 }, function (err) {
     t.error(err)
-    fastify.server.unref()
+    t.teardown(() => { fastify.close() })
 
     sget({
       method: 'POST',

diff --git a/test/custom-parser.test.js b/test/custom-parser.test.js
@@ -124,7 +124,7 @@ test('contentTypeParser should handle multiple custom parsers', t => {
 
   fastify.listen({ port: 0 }, err => {
     t.error(err)
-    fastify.server.unref()
+    t.teardown(() => { fastify.close() })
 
     sget({
       method: 'POST',
@@ -176,7 +176,7 @@ test('contentTypeParser should handle an array of custom contentTypes', t => {
 
   fastify.listen({ port: 0 }, err => {
     t.error(err)
-    fastify.server.unref()
+    t.teardown(() => { fastify.close() })
 
     sget({
       method: 'POST',
@@ -966,7 +966,7 @@ test('Should parse empty bodies as a string', t => {
 
   fastify.listen({ port: 0 }, err => {
     t.error(err)
-    fastify.server.unref()
+    t.teardown(() => { fastify.close() })
 
     sget({
       method: 'POST',

diff --git a/test/decorator.test.js b/test/decorator.test.js
@@ -134,7 +134,7 @@ test('decorateReply inside register', t => {
 
   fastify.listen({ port: 0 }, err => {
     t.error(err)
-    fastify.server.unref()
+    t.teardown(() => { fastify.close() })
 
     sget({
       method: 'GET',
@@ -182,7 +182,7 @@ test('decorateReply as plugin (inside .after)', t => {
 
   fastify.listen({ port: 0 }, err => {
     t.error(err)
-    fastify.server.unref()
+    t.teardown(() => { fastify.close() })
 
     sget({
       method: 'GET',
@@ -230,7 +230,7 @@ test('decorateReply as plugin (outside .after)', t => {
 
   fastify.listen({ port: 0 }, err => {
     t.error(err)
-    fastify.server.unref()
+    t.teardown(() => { fastify.close() })
 
     sget({
       method: 'GET',
@@ -276,7 +276,7 @@ test('decorateRequest inside register', t => {
 
   fastify.listen({ port: 0 }, err => {
     t.error(err)
-    fastify.server.unref()
+    t.teardown(() => { fastify.close() })
 
     sget({
       method: 'GET',
@@ -324,7 +324,7 @@ test('decorateRequest as plugin (inside .after)', t => {
 
   fastify.listen({ port: 0 }, err => {
     t.error(err)
-    fastify.server.unref()
+    t.teardown(() => { fastify.close() })
 
     sget({
       method: 'GET',
@@ -372,7 +372,7 @@ test('decorateRequest as plugin (outside .after)', t => {
 
   fastify.listen({ port: 0 }, err => {
     t.error(err)
-    fastify.server.unref()
+    t.teardown(() => { fastify.close() })
 
     sget({
       method: 'GET',
@@ -951,7 +951,7 @@ test('decorateRequest/decorateReply empty string', t => {
 
   fastify.listen({ port: 0 }, err => {
     t.error(err)
-    fastify.server.unref()
+    t.teardown(() => { fastify.close() })
 
     sget({
       method: 'GET',
@@ -980,7 +980,7 @@ test('decorateRequest/decorateReply is undefined', t => {
 
   fastify.listen({ port: 0 }, err => {
     t.error(err)
-    fastify.server.unref()
+    t.teardown(() => { fastify.close() })
 
     sget({
       method: 'GET',
@@ -1009,7 +1009,7 @@ test('decorateRequest/decorateReply is not set to a value', t => {
 
   fastify.listen({ port: 0 }, err => {
     t.error(err)
-    fastify.server.unref()
+    t.teardown(() => { fastify.close() })
 
     sget({
       method: 'GET',

diff --git a/test/delete.test.js b/test/delete.test.js
@@ -159,7 +159,7 @@ test('body - delete', t => {
 
 fastify.listen({ port: 0 }, err => {
   t.error(err)
-  fastify.server.unref()
+  t.teardown(() => { fastify.close() })
 
   test('shorthand - request delete', t => {
     t.plan(4)

diff --git a/test/get.test.js b/test/get.test.js
@@ -205,7 +205,7 @@ test('send a falsy boolean', t => {
 
 fastify.listen({ port: 0 }, err => {
   t.error(err)
-  fastify.server.unref()
+  t.teardown(() => { fastify.close() })
 
   test('shorthand - request get', t => {
     t.plan(4)

diff --git a/test/head.test.js b/test/head.test.js
@@ -94,7 +94,7 @@ test('missing schema - head', t => {
 
 fastify.listen({ port: 0 }, err => {
   t.error(err)
-  fastify.server.unref()
+  t.teardown(() => { fastify.close() })
 
   test('shorthand - request head', t => {
     t.plan(2)

diff --git a/test/helper.js b/test/helper.js
@@ -98,7 +98,7 @@ module.exports.payloadMethod = function (method, t, isSetErrorHandler = false) {
       return
     }
 
-    fastify.server.unref()
+    t.teardown(() => { fastify.close() })
 
     test(`${upMethod} - correctly replies`, t => {
       t.plan(3)

diff --git a/test/hooks-async.test.js b/test/hooks-async.test.js
@@ -58,7 +58,7 @@ test('async hooks', t => {
 
   fastify.listen({ port: 0 }, err => {
     t.error(err)
-    fastify.server.unref()
+    t.teardown(() => { fastify.close() })
 
     sget({
       method: 'GET',

diff --git a/test/hooks.test.js b/test/hooks.test.js
@@ -140,7 +140,7 @@ test('hooks', t => {
 
   fastify.listen({ port: 0 }, err => {
     t.error(err)
-    fastify.server.unref()
+    t.teardown(() => { fastify.close() })
 
     sget({
       method: 'GET',
@@ -263,7 +263,7 @@ test('onRequest hook should support encapsulation / 3', t => {
 
   fastify.listen({ port: 0 }, err => {
     t.error(err)
-    fastify.server.unref()
+    t.teardown(() => { fastify.close() })
 
     sget({
       method: 'GET',
@@ -324,7 +324,7 @@ test('preHandler hook should support encapsulation / 5', t => {
 
   fastify.listen({ port: 0 }, err => {
     t.error(err)
-    fastify.server.unref()
+    t.teardown(() => { fastify.close() })
 
     sget({
       method: 'GET',
@@ -735,7 +735,7 @@ test('onRoute hook should able to change the route url', t => {
 
   fastify.listen({ port: 0 }, err => {
     t.error(err)
-    fastify.server.unref()
+    t.teardown(() => { fastify.close() })
 
     sget({
       method: 'GET',
@@ -920,7 +920,7 @@ test('onResponse hook should support encapsulation / 3', t => {
 
   fastify.listen({ port: 0 }, err => {
     t.error(err)
-    fastify.server.unref()
+    t.teardown(() => { fastify.close() })
 
     sget({
       method: 'GET',
@@ -997,7 +997,7 @@ test('onSend hook should support encapsulation / 2', t => {
 
   fastify.listen({ port: 0 }, err => {
     t.error(err)
-    fastify.server.unref()
+    t.teardown(() => { fastify.close() })
 
     sget({
       method: 'GET',
@@ -1261,7 +1261,8 @@ test('onSend hook throws', t => {
 
   fastify.listen({ port: 0 }, err => {
     t.error(err)
-    fastify.server.unref()
+    t.teardown(() => { fastify.close() })
+
     sget({
       method: 'GET',
       url: 'http://localhost:' + fastify.server.address().port
@@ -2391,7 +2392,7 @@ test('preValidation hook should support encapsulation / 3', t => {
 
   fastify.listen({ port: 0 }, err => {
     t.error(err)
-    fastify.server.unref()
+    t.teardown(() => { fastify.close() })
 
     sget({
       method: 'GET',
@@ -2538,7 +2539,7 @@ test('preParsing hook should run before parsing and be able to modify the payloa
 
   fastify.listen({ port: 0 }, err => {
     t.error(err)
-    fastify.server.unref()
+    t.teardown(() => { fastify.close() })
 
     sget({
       method: 'POST',
@@ -2581,7 +2582,7 @@ test('preParsing hooks should run in the order in which they are defined', t =>
 
   fastify.listen({ port: 0 }, err => {
     t.error(err)
-    fastify.server.unref()
+    t.teardown(() => { fastify.close() })
 
     sget({
       method: 'POST',
@@ -2631,7 +2632,7 @@ test('preParsing hooks should support encapsulation', t => {
 
   fastify.listen({ port: 0 }, err => {
     t.error(err)
-    fastify.server.unref()
+    t.teardown(() => { fastify.close() })
 
     sget({
       method: 'POST',
@@ -2752,7 +2753,7 @@ test('preParsing hook should support encapsulation / 3', t => {
 
   fastify.listen({ port: 0 }, err => {
     t.error(err)
-    fastify.server.unref()
+    t.teardown(() => { fastify.close() })
 
     sget({
       method: 'GET',
@@ -2814,7 +2815,7 @@ test('preSerialization hook should run before serialization and be able to modif
 
   fastify.listen({ port: 0 }, err => {
     t.error(err)
-    fastify.server.unref()
+    t.teardown(() => { fastify.close() })
 
     sget({
       method: 'GET',
@@ -2865,7 +2866,7 @@ test('preSerialization hook should be able to throw errors which are validated a
 
   fastify.listen({ port: 0 }, err => {
     t.error(err)
-    fastify.server.unref()
+    t.teardown(() => { fastify.close() })
 
     sget({
       method: 'GET',
@@ -2899,7 +2900,7 @@ test('preSerialization hook which returned error should still run onError hooks'
 
   fastify.listen({ port: 0 }, err => {
     t.error(err)
-    fastify.server.unref()
+    t.teardown(() => { fastify.close() })
 
     sget({
       method: 'GET',
@@ -2933,7 +2934,7 @@ test('preSerialization hooks should run in the order in which they are defined',
 
   fastify.listen({ port: 0 }, err => {
     t.error(err)
-    fastify.server.unref()
+    t.teardown(() => { fastify.close() })
 
     sget({
       method: 'GET',
@@ -2977,7 +2978,7 @@ test('preSerialization hooks should support encapsulation', t => {
 
   fastify.listen({ port: 0 }, err => {
     t.error(err)
-    fastify.server.unref()
+    t.teardown(() => { fastify.close() })
 
     sget({
       method: 'GET',

diff --git a/test/http2/closing.test.js b/test/http2/closing.test.js
@@ -34,7 +34,7 @@ t.test('http/2 request while fastify closing', t => {
 
   fastify.listen({ port: 0 }, err => {
     t.error(err)
-    fastify.server.unref()
+    t.teardown(() => { fastify.close() })
 
     t.test('return 200', t => {
       const url = getUrl(fastify)
@@ -81,7 +81,7 @@ t.test('http/2 request while fastify closing - return503OnClosing: false', t =>
 
   fastify.listen({ port: 0 }, err => {
     t.error(err)
-    fastify.server.unref()
+    t.teardown(() => { fastify.close() })
 
     t.test('return 200', t => {
       const url = getUrl(fastify)

diff --git a/test/http2/constraint.test.js b/test/http2/constraint.test.js
@@ -48,7 +48,7 @@ test('A route supports host constraints under http2 protocol and secure connecti
 
   fastify.listen({ port: 0 }, err => {
     t.error(err)
-    fastify.server.unref()
+    t.teardown(() => { fastify.close() })
 
     t.test('https get request - no constrain', async (t) => {
       t.plan(3)

diff --git a/test/http2/head.test.js b/test/http2/head.test.js
@@ -22,7 +22,7 @@ fastify.all('/', function (req, reply) {
 
 fastify.listen({ port: 0 }, err => {
   t.error(err)
-  fastify.server.unref()
+  t.teardown(() => { fastify.close() })
 
   test('http HEAD request', async (t) => {
     t.plan(1)

diff --git a/test/http2/plain.test.js b/test/http2/plain.test.js
@@ -26,7 +26,7 @@ fastify.get('/hostname', function (req, reply) {
 
 fastify.listen({ port: 0 }, err => {
   t.error(err)
-  fastify.server.unref()
+  t.teardown(() => { fastify.close() })
 
   test('http get request', async (t) => {
     t.plan(3)

diff --git a/test/http2/secure-with-fallback.test.js b/test/http2/secure-with-fallback.test.js
@@ -42,7 +42,7 @@ test('secure with fallback', (t) => {
 
   fastify.listen({ port: 0 }, err => {
     t.error(err)
-    fastify.server.unref()
+    t.teardown(() => { fastify.close() })
 
     t.test('https get error', async (t) => {
       t.plan(1)