Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix package-manager CI #2189

Merged
merged 2 commits into from
Apr 8, 2020
Merged

Fix package-manager CI #2189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c969dc5
Do not support Yarn for LTS
mcollina Apr 8, 2020
998f79a
fixup
mcollina Apr 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/package-manager-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,14 @@ jobs:
strategy:
matrix:
# Maintenance and active LTS
node-version: [8.x, 10.x]
node-version: [8.x, 10.x, 12.x]
os: [ubuntu-16.04]

steps:
- uses: actions/checkout@v1

- name: Use Node.js
uses: actions/setup-node@v1
uses: actions/setup-node@v2
with:
node-version: ${{ matrix.node-version }}

Expand All @@ -38,21 +38,21 @@ jobs:
strategy:
matrix:
# Maintenance and active LTS
node-version: [8.x, 10.x]
node-version: [8.x, 10.x, 12.x]
os: [ubuntu-16.04]

steps:
- uses: actions/checkout@v1

- name: Use Node.js
uses: actions/setup-node@v1
uses: actions/setup-node@v2
with:
node-version: ${{ matrix.node-version }}

- name: Install with yarn
run: |
curl -o- -L https://yarnpkg.com/install.sh | bash
yarn install
yarn install --ignore-engines

- name: Run tests
run: |
Expand Down
23 changes: 13 additions & 10 deletions docs/LTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,18 +31,21 @@ A "month" is to be a period of 30 consecutive days.

### Schedule

| Version | Release Date | End Of LTS Date | Node.js |
| :------ | :----------- | :-------------- | :-------------- |
| 1.0.0 | 2018-03-06 | 2019-09-01 | 6, 8, 9, 10, 11 |
| 2.0.0 | 2019-02-25 | TBD | 6, 8, 10, 11 |
| Version | Release Date | End Of LTS Date | Node.js |
| :------ | :----------- | :-------------- | :------------------- |
| 1.0.0 | 2018-03-06 | 2019-09-01 | 6, 8, 9, 10, 11 |
| 2.0.0 | 2019-02-25 | TBD | 6, 8, 10, 11, 12, 13 |

<a name="supported-os"></a>

### CI tested operating systems

| CI | OS | Version | Package Manager | Node.js |
|----------------|---------|------------------------|---------------------------|-----------|
| Github Actions | Linux | Ubuntu 16.04 | npm | 6,8,10,12 |
| Github Actions | Linux | Ubuntu 16.04 | yarn,pnpm | 8,10 |
| Github Actions | Windows | Windows Server 2016 R2 | npm | 6,8,10,12 |
| Github Actions | MacOS | macOS X Mojave 10.14 | npm | 6,8,10,12 |
| OS | Version | Package Manager | Node.js |
|---------|------------------------|---------------------------|-----------|
| Linux | Ubuntu 16.04 | npm | 6,8,10,12 |
| Linux | Ubuntu 16.04 | pnpm | 8,10,12 |
| Linux | Ubuntu 16.04 | yarn | 8,10,12 |
| Windows | Windows Server 2016 R2 | npm | 6,8,10,12 |
| MacOS | macOS X Mojave 10.14 | npm | 6,8,10,12 |

Using yarn might require passing the `--ignore-engines` flag.