fix: request set headers

[Eomm]

Fix #2813

The use case is:
some validation framework returns an object as results of the validation { value: <validated object with defaults> }.
In this case, we must set that object as the request.headers value.

Before #2426 we had a private headers property that was customized and it was acting like a mirror of the raw.headers object.
Now, with this PR, it becomes possible to manage the HTTPIncompingRequest's headers, so, for example, the onRequest hooks will read headers that could be totally different in the preHandler hooks because of the validation process.

What do you think?

(In any case, this PR needs more tests)

Checklist

• run npm run test and npm run benchmark
• tests and/or benchmarks are included
• documentation is changed or added
• commit message and code follows the Developer's Certification of Origin
  and the Code of conduct

[mcollina]

I prefer to not alter req.raw.headers. An alternative implementation is to redefine the headers property on request in the setter, bypassing the getter and use a newly stored value.

[mcollina]

looks good so far

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[mcollina]

@Eomm are you still pursuiing this?

[Eomm]

@Eomm are you still pursuiing this?

Yes, I implemented the I prefer to not alter req.raw.headers. change requested, keeping the headers separated and trying to do not impact normal flow.

[mcollina]

lgtm

[zekth]

Minor spelling comment. Otherwise lgtm

[zekth]

lgtm!

[mcollina]

lgtm

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.