Set exposeHeadRoutes: true by default #2826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
commented
Jan 31, 2021
lib/route.js
Outdated
| const config = opts.config || {} | ||
| config.url = url | ||
| config.method = opts.method | ||
| const config = Object.assign({ url, method: opts.method }, opts.config) |
There was a problem hiding this comment.
This is a bad bug that's present on master as well.
There was a problem hiding this comment.
Fixed in master with #2827
|
I took the lazy route and disabled the HEAD routes in certain tests. Updating them would have made more complex to read from my point of view. |
L2jLiga
reviewed
Jan 31, 2021
3 tasks
fox1t
approved these changes
Feb 1, 2021
zekth
approved these changes
Feb 1, 2021
salmanm
approved these changes
Feb 1, 2021
mcollina
force-pushed
the
expose-head-by-default
branch
from
d750e4f
to
0a6d9a2
Compare
|
PTAL, I've rebased. |
salmanm
approved these changes
Feb 2, 2021
Following this one: #2700 |
jsumners
approved these changes
Feb 2, 2021
mcollina
added
semver-major
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct