fix: handle invalid url #3128
Merged
fix: handle invalid url #3128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zekth
approved these changes
Jun 10, 2021
Eomm
reviewed
Jun 10, 2021
jsumners
reviewed
Jun 10, 2021
jsumners
reviewed
Jun 10, 2021
climba03003
commented
Jun 10, 2021
lib/fourOhFour.js
Outdated
| const body = `{"error":"Not Found","message":"${message}","statusCode":404}` | ||
|
|
||
| // simulate normal route logging | ||
| const id = genReqId(req) |
There was a problem hiding this comment.
I would like to have some feedback about the logging. Do we have a better approach for this one?
This was referenced Mar 31, 2022
mcollina
pushed a commit
that referenced
this pull request
Apr 1, 2022
* fix: handle invalid url (#3128) * fix: handle invalid url * refactor: handle as 404 instead of 400 * fix: respect disableRequestLogging * chore: linting * feat: allow to customize 404 onBadUrl handler
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3127
Checklist
npm run testandnpm run benchmarkand the Code of conduct