Updated the docs related to AJV plugins #3189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
mcollina
reviewed
Jul 12, 2021
Eomm
reviewed
Jul 12, 2021
jsumners
reviewed
Jul 12, 2021
docs/Validation-and-Serialization.md
Outdated
Comment on lines
604
to
613
| Below is an example showing how to add **custom error messages for each property** of a schema by supplying custom AJV options. | ||
| Inline comments in the schema below describe how to configure it to show a different error message for each case: | ||
|
|
||
| ```js | ||
| const fastify = Fastify({ | ||
| ajv: { | ||
| customOptions: { jsonPointers: true }, | ||
| customOptions: { | ||
| jsonPointers: true, | ||
| allErrors: true | ||
| }, |
There was a problem hiding this comment.
Oof. We need to update this example with a warning that implementing it opens the service up to a denial of service attack.
There was a problem hiding this comment.
Should I just add the warning as a comment in front of the option:
customOptions: {
jsonPointers: true,
allErrors: true // Warning: Enabling this option may open the service up to a denial of service attack
},
There was a problem hiding this comment.
I would add a note box with the link to the CVE
https://www.cvedetails.com/cve/CVE-2020-8192/
|
What's the status of this? Should we land some of this or should we close for now? |
Eomm
requested changes
Sep 12, 2021
Co-authored-by: Matteo Collina <matteo.collina@gmail.com>
Co-authored-by: Manuel Spigolon <behemoth89@gmail.com>
Eomm
reviewed
Oct 19, 2021
Co-authored-by: Manuel Spigolon <behemoth89@gmail.com>
Eomm
approved these changes
Oct 20, 2021
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ajv-errorsplugin