Extend content type parser #3210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
reviewed
Jul 24, 2021
lib/contentTypeParser.js
Outdated
| } | ||
|
|
||
| if (Array.isArray(contentType)) { | ||
| contentType.forEach((type) => this[kContentTypeParser].remove(type)) |
There was a problem hiding this comment.
Can you please use a for..of loop?
There was a problem hiding this comment.
I will change it later! I used forEach because it is also used here.
climba03003
reviewed
Jul 24, 2021
docs/ContentTypeParser.md
Outdated
| fastiy.removeContentTypeParser(['application/json', 'text/plain']) | ||
| ``` | ||
|
|
||
| #### resetContentTypeParsers |
There was a problem hiding this comment.
I think the name can be improved. Reset sounds to me reset to some point which mostly reset to default value.
It would be better if it called removeAll.
There was a problem hiding this comment.
Makes sense to me! I will update the name
This was referenced Aug 2, 2021
This was referenced Aug 2, 2021
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct
Closes #2994. This PR adds the 2 methods
resetContentTypeParsersandremoveContentTypeParserto the Fastify instance. WithresetContentTypeParsersall current content type parser can be deleted (including the both built-in content type parsers). This is especially useful if you want to implement a catch-all content type parser that should be called even if the content type isapplication/json. WithremoveContentTypeParsera single or an array of content type parsers can be removed. Both APIs support encapsulation.