Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add file option in FastifyLoggerOptions interface #3214

Merged
merged 3 commits into from Jul 28, 2021
Merged

fix: add file option in FastifyLoggerOptions interface #3214

merged 3 commits into from Jul 28, 2021

Conversation

nicks96432
Copy link
Contributor

@nicks96432 nicks96432 commented Jul 25, 2021 •
edited

Checklist

@github-actions github-actions bot added the typescript TypeScript related label Jul 25, 2021
Eomm
Eomm reviewed Jul 25, 2021
View reviewed changes
Copy link
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding a test here?

@nicks96432 nicks96432 requested a review from Eomm July 26, 2021 00:34
Eomm
Eomm approved these changes Jul 26, 2021
View reviewed changes
Copy link
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

RafaelGSS
RafaelGSS approved these changes Jul 26, 2021
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mcollina mcollina merged commit 52afb4a into fastify:main Jul 28, 2021
This was referenced Aug 2, 2021
Merged
Merged
Closed
Merged
Merged
Merged
Closed
Open
Merged
Open
Closed
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Open
This was referenced Aug 2, 2021
Merged
Closed
Merged
Merged
Open
Merged
Merged
Merged
Merged
Merged
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Eomm Eomm Eomm approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
typescript TypeScript related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nicks96432 @Eomm @RafaelGSS @mcollina