Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add info about Reply generic interface #3223

Merged
merged 1 commit into from Aug 4, 2021
Merged

Conversation

shwao
Copy link
Contributor

@shwao shwao commented Jul 31, 2021

The third point in "Using Generics" says

"The shorthand route methods (i.e. .get) accept a generic object RequestGenericInterface".

But the route methods actually accept the generic object RouteGenericInterface which consists of RequestGenericInterface and ReplyGenericInterface. The ReplyGenericInterface adds the Reply interface to the list of interfaces.

Checklist

The third point in "Using Generics" says

"The shorthand route methods (i.e. .get) accept a generic object `RequestGenericInterface`".

But the route methods actually accept the generic object `RouteGenericInterface` which consists of `RequestGenericInterface` and `ReplyGenericInterface`. The `ReplyGenericInterface` adds the `Reply` interface to the list of interfaces.
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 31, 2021
@RafaelGSS RafaelGSS requested a review from a team July 31, 2021 19:02
@mcollina
Copy link
Member

mcollina commented Aug 1, 2021

cc @fastify/typescript

Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good catch!

@RafaelGSS RafaelGSS merged commit 36bca51 into fastify:main Aug 4, 2021
@github-actions
Copy link

github-actions bot commented Aug 5, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants