Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify getting started #3241

Merged
merged 2 commits into from Aug 9, 2021
Merged

Clarify getting started #3241

merged 2 commits into from Aug 9, 2021

Conversation

hugocaillard
Copy link
Contributor

While reading the Getting Started guide, I was confused because I couldn't find where we "used the decorate API" until I understood that it's actually the MongoDB plugin that does use it.

I quickly investigated to find out that the code used to actually call fastify.decorate() but it's not the case anymore thanks to the plugin.

Checklist

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 8, 2021
docs/Getting-Started.md Outdated Show resolved Hide resolved
Co-authored-by: Vincent LE GOFF <vince.legoff@gmail.com>
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit a90c68b into fastify:main Aug 9, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants