adding type for fastify.routing

[axe-me]

adding missing type declaration for https://www.fastify.io/docs/latest/Server/#routing

[mcollina]

Could you add a test for those types? We use tsd.

[axe-me]

@mcollina Thanks for reviewing this PR. I just added a simple test, please take a look.

[climba03003]

At first glance, no problem. But I never use this method, I cannot confirm if the type is correct.

[Eomm]

Side note: I was unable to find a test for this method in the test/ folder.

This snippet just let the server crash (I think it creates an infinite loop)

const fastify = require('fastify')({ logger: true })
fastify.get('/', async (request, reply) => {
  fastify.routing(request.raw, reply.raw)
  return { hello: 'world' }
})
fastify.listen(8080)

[climba03003]

fastify.routing(request.raw, reply.raw)

@Eomm Yes, it is created an infinite loop. This method found the handler and it will execute the handler.

When you use it inside the handler to pass it's own Request and Response. It will found and execute itself again and again.

[axe-me]

Side note: I was unable to find a test for this method in the test/ folder.

This snippet just let the server crash (I think it creates an infinite loop)

const fastify = require('fastify')({ logger: true })
fastify.get('/', async (request, reply) => {
  fastify.routing(request.raw, reply.raw)
  return { hello: 'world' }
})
fastify.listen(8080)

Hi @Eomm, I think this instance method is for handling requests from other instance or HTTP server. e.g.:

const naviteHttpServer = http.createServer((req, res) => {
  fastify.routing(req, res)
})

this is my use case at least, https://github.com/axe-me/vite-plugin-node/blob/main/src/server/fastify.ts#L8

This method is quite useful for passing raw requests from another frameworks like express/koa to fastify programmatically without using a HTTP proxy.

cc @climba03003

[Eomm]

Thanks for sharing your use case.
We could add a safe-check to avoid this crash, but it is not about your PR.

[mcollina]

lgtm

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.