Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs:inform user to set target property #3291

Merged
merged 2 commits into from Oct 13, 2021

Conversation

siemah
Copy link
Contributor

@siemah siemah commented Sep 3, 2021

Inform user to set the target property in tsconfig.json file to avoid warnings such as [FSTDEP004] FastifyDeprecation.

Checklist

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 3, 2021
@siemah
Copy link
Contributor Author

siemah commented Sep 4, 2021

Is there anything that i did wrong?

@mcollina mcollina requested review from zekth, Ethan-Arrowood and a team September 4, 2021 20:26
@zekth
Copy link
Member

zekth commented Sep 24, 2021

I'd change it to the comment @climba03003 said in the issue:

Change the target greater than es2017 will solve the issue

esnext can be potentially problematic.

docs/TypeScript.md Outdated Show resolved Hide resolved
@Eomm Eomm added the typescript TypeScript related label Oct 13, 2021
Co-authored-by: KaKa <climba03003@gmail.com>
@github-actions github-actions bot removed the typescript TypeScript related label Oct 13, 2021
Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@RafaelGSS RafaelGSS merged commit f796b75 into fastify:main Oct 13, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants