Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NGINX section with comments and fixes #3352

Merged
merged 1 commit into from Sep 30, 2021
Merged

Update NGINX section with comments and fixes #3352

merged 1 commit into from Sep 30, 2021

Conversation

weiliddat
Copy link
Contributor

I've added comments to potentially close #3300. I've mostly added what the directives and options mean in NGINX, and some basic recommendations. I assumed that the target audience does not necessarily know NGINX that well, and more advanced configurations/explanations are out of scope of the sample config.

I've rearranged some of the SSL configs so it's obvious what is needed and what is optional (OCSP stapling for example).

The proxy_pass directive does not need a port if you are using an upstream group. NGINX will also tell you that it's an error.

Checklist

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 30, 2021
@mcollina mcollina merged commit ba36475 into fastify:main Sep 30, 2021
@github-actions
Copy link

github-actions bot commented Oct 1, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NGINX docs
3 participants