Update NGINX section with comments and fixes #3352
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added comments to potentially close #3300. I've mostly added what the directives and options mean in NGINX, and some basic recommendations. I assumed that the target audience does not necessarily know NGINX that well, and more advanced configurations/explanations are out of scope of the sample config.
I've rearranged some of the SSL configs so it's obvious what is needed and what is optional (OCSP stapling for example).
The proxy_pass directive does not need a port if you are using an upstream group. NGINX will also tell you that it's an error.
Checklist
npm run test
andnpm run benchmark
and the Code of conduct