Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop readable-stream dependency #3372

Merged
merged 1 commit into from Oct 14, 2021
Merged

Drop readable-stream dependency #3372

merged 1 commit into from Oct 14, 2021

Conversation

mcollina
Copy link
Member

It's not really needed and it's just more dependencies that we are bringing along.

See #3371

Checklist

@mcollina mcollina requested review from jsumners, climba03003 and Eomm and removed request for climba03003 October 14, 2021 08:47
Copy link
Member

@zekth zekth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Eomm Eomm merged commit 1e186f4 into main Oct 14, 2021
@Eomm Eomm deleted the use-native-stream-module branch October 14, 2021 14:58
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants