Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused types imports #3392

Merged
merged 1 commit into from Oct 24, 2021

Conversation

juanpicado
Copy link
Contributor

@juanpicado juanpicado commented Oct 24, 2021

Clean up some unused imports on Types tests.

Checklist

@github-actions github-actions bot added test Issue or pr related to our testing infrastructure. typescript TypeScript related labels Oct 24, 2021
@juanpicado juanpicado marked this pull request as ready for review October 24, 2021 19:45
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how did you spot them?

@juanpicado
Copy link
Contributor Author

how did you spot them?

trying to figure out how to type a decorateRequest by reading the types tests files, vcode displays them grayish, so I check all type test files, I've only found those by far.

@mcollina
Copy link
Member

I think we should improve the docs if that's not clear! Anyhow, good work!

@mcollina mcollina merged commit 149c03f into fastify:main Oct 24, 2021
@juanpicado juanpicado deleted the remove-unused-import branch October 24, 2021 21:21
@moises-marquez
Copy link

@mcollina, there's a handy prettier plugin that detects unused imports and automatically removes them. I can really recommend it: https://www.npmjs.com/package/prettier-plugin-organize-imports

@zekth
Copy link
Member

zekth commented Nov 7, 2021

@mcollina, there's a handy prettier plugin that detects unused imports and automatically removes them. I can really recommend it: https://www.npmjs.com/package/prettier-plugin-organize-imports

We tried to bring back ts-standard several times that would allow us to detect those kind of issues and be inline with the code style of the library itself. Unfortunately we've been stuck on several types definition

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
test Issue or pr related to our testing infrastructure. typescript TypeScript related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants