Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(test/bundler): grammar and spelling fixes #3393

Merged
merged 4 commits into from Oct 25, 2021
Merged

docs(test/bundler): grammar and spelling fixes #3393

merged 4 commits into from Oct 25, 2021

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Oct 25, 2021

Checklist

@github-actions github-actions bot added the test Issue or pr related to our testing infrastructure. label Oct 25, 2021
@zekth zekth requested a review from jsumners October 25, 2021 10:58
zekth
zekth approved these changes Oct 25, 2021
View reviewed changes
Copy link
Member

@zekth zekth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd wait for @jsumners input to confirm.

jsumners
jsumners approved these changes Oct 25, 2021
View reviewed changes
test/bundler/README.md Outdated Show resolved Hide resolved
test/bundler/README.md Outdated Show resolved Hide resolved
test/bundler/README.md Outdated Show resolved Hide resolved
Fdawgs and others added 3 commits October 25, 2021 11:53
@Fdawgs @jsumners
Update test/bundler/README.md
c06b595 
Co-authored-by: James Sumners <james@sumners.email>
@Fdawgs @jsumners
Update test/bundler/README.md
4fa93a3 
Co-authored-by: James Sumners <james@sumners.email>
@Fdawgs @jsumners
Update test/bundler/README.md
a3817b6 
Co-authored-by: James Sumners <james@sumners.email>
RafaelGSS
RafaelGSS approved these changes Oct 25, 2021
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@RafaelGSS RafaelGSS merged commit 705a505 into fastify:main Oct 25, 2021
@RafaelGSS RafaelGSS added the documentation Improvements or additions to documentation label Oct 25, 2021
@Fdawgs Fdawgs deleted the docs/bundlers branch October 25, 2021 12:41
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jsumners jsumners jsumners approved these changes

@zekth zekth zekth approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation test Issue or pr related to our testing infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Fdawgs @jsumners @zekth @RafaelGSS