fix: setSchemaController not inheriting Schemas from root parent

[metcoder95]

As stated in #3121, during the development of the plugin I noticed that when setting up a custom SchemaController on the second level of encapsulation (root -> instance), the custom Validator is not correctly inheriting the schemas defined on the root layer of encapsulation. Causing the following error:

Failed building the validation schema for POST: /, due to error can't resolve reference some# from id #

Full Reproduction in the test case added.

Checklist

• run npm run test and npm run benchmark
• tests and/or benchmarks are included
• documentation is changed or added
• commit message and code follows the Developer's Certification of Origin
  and the Code of conduct

[mcollina]

lgtm

[metcoder95]

Hi @Eomm, I adjusted the tests as you suggested in the following commit 4dd513b

Thanks to that, I notice that thanks to the change, the buildSerializer was missed in the chain, as when overwriting the SchemaController, neither the constructor nor the buildSchemaController static function was taking into consideration the compilersFactory at all, trying to always reach them at the instance level.

I added the function getCompilersFactory to the instance of the controller, in order to do a recursive search over the chain of controller till reaches the most recent buildSerializer implementation.

Please let me know what you think about this approach, not so sure if is the right approach as it might be better to even decouple it a little and have one function for the buildSerializer, and another one for the buildValidator.

Note:

• The coverage decreased because the change, I'll work on set it back to 100% during the weekend 👍

[metcoder95]

Done, please feel free to have a look when you have time 🙂

[zekth]

Minor remark. Overall LGTM.

Good catch on this.

[FAVE01]

nice

[Eomm]

GREAT test cases 👏🏽

Almost done!

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.