Adjust existing PRs for the new reply.sent handing #3444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergejostir
force-pushed
the
pr/adjust-existing-prs-for-the-new-reply.sent-handing
branch
from
1dc6d13
to
21f7050
Compare
|
Why a separate PR? Couldn't we just cherry-pick the commit? |
|
Probably, but how can I propose that? And how would that be better than a PR? |
|
I have updated the |
1 task
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct
This PR adjusts some of the already merged PRs, so they are in line with the new way that reply.sent is handled (introduced in #3072).
#3261 & #3285: kReplySent does not exist anymore. We can simply delete those lines since they don't have any effect.
#3318: With the new way that the reply is handled, we do not have to do anything manually any more. Only the test had to be adjusted because of the reasoning explained in #3132.