Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: server.requestTimeout miss when https #3447

Merged
merged 2 commits into from
Nov 16, 2021

Conversation

gzqby
Copy link
Contributor

@gzqby gzqby commented Nov 16, 2021

Checklist

@climba03003
Copy link
Member

Can you add an unit test for the server configuration?
https://github.com/fastify/fastify/blob/main/test/requestTimeout.test.js

@gzqby
Copy link
Contributor Author

gzqby commented Nov 16, 2021

ok

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit ea0e901 into fastify:main Nov 16, 2021
@renovate renovate bot mentioned this pull request Feb 16, 2022
1 task
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants