Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): define instance listen callback error nullable #3449

Conversation

sf3ris
Copy link
Contributor

@sf3ris sf3ris commented Nov 16, 2021

Description

Fixes #3448

Checklist

@github-actions github-actions bot added the typescript TypeScript related label Nov 16, 2021
@mcollina
Copy link
Member

Why draft?

@sf3ris
Copy link
Contributor Author

sf3ris commented Nov 16, 2021

Why draft?

Was waiting for CI to run, to set it ready for review

@sf3ris sf3ris marked this pull request as ready for review November 16, 2021 13:46
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eomm Eomm merged commit f15c557 into fastify:main Nov 16, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
typescript TypeScript related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instance listen method definition - callback's Error should be nullable
3 participants