Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(typescript): add type declaration for FastifyRequest.context #3472

Merged
merged 1 commit into from
Nov 21, 2021
Merged

fix(typescript): add type declaration for FastifyRequest.context #3472

merged 1 commit into from
Nov 21, 2021

Conversation

chrskrchr
Copy link
Contributor

@chrskrchr chrskrchr commented Nov 20, 2021 •
edited

Checklist

@github-actions github-actions bot added the typescript TypeScript related label Nov 20, 2021
@chrskrchr
Copy link
Contributor Author

This PR is the result of a recommendation from @climba03003 in #2989

#2989 (comment)

It types the FastifyRequest.context field exactly the same as FastifyReply.context.

@chrskrchr chrskrchr marked this pull request as ready for review November 20, 2021 19:05
@chrskrchr chrskrchr mentioned this pull request Nov 20, 2021
Closed
4 tasks
mcollina
mcollina approved these changes Nov 20, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

cc @fastify/typescript

climba03003
climba03003 approved these changes Nov 21, 2021
View reviewed changes
Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mcollina mcollina merged commit b55ec60 into fastify:main Nov 21, 2021
@chrskrchr chrskrchr deleted the ck.requestContextType branch November 21, 2021 17:13
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcollina mcollina mcollina approved these changes

@climba03003 climba03003 climba03003 approved these changes

Assignees
No one assigned
Labels
typescript TypeScript related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chrskrchr @mcollina @climba03003