Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: change port to random #3740

Merged
merged 5 commits into from Mar 4, 2022
Merged

test: change port to random #3740

merged 5 commits into from Mar 4, 2022

Conversation

xtx1130
Copy link
Contributor

@xtx1130 xtx1130 commented Mar 3, 2022

ref: #3737 (comment)

Checklist

@github-actions github-actions bot added the test Issue or pr related to our testing infrastructure. label Mar 3, 2022
@mcollina
Copy link
Member

mcollina commented Mar 3, 2022

Can you try rebase?

@github-actions github-actions bot removed the test Issue or pr related to our testing infrastructure. label Mar 3, 2022
@xtx1130
Copy link
Contributor Author

xtx1130 commented Mar 3, 2022

Can you try rebase?

like this?

@@ -5,7 +5,7 @@ on:
paths-ignore:
- 'docs/**'
- '*.md'
pull_request_target:
pull_request:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this file changed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref: #3741. And I rebased from master

@@ -27,6 +27,7 @@ jobs:

- name: Lint code
run: |
echo 'this is an update'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test for github ci update. I have seen Mcollina has new commit to delete this, and I will have a merge

test/als.test.js Outdated Show resolved Hide resolved
xtx1130 and others added 2 commits March 4, 2022 09:33
Co-authored-by: James Sumners <james@sumners.email>
@github-actions github-actions bot added the test Issue or pr related to our testing infrastructure. label Mar 4, 2022
@Eomm Eomm merged commit 3d67e88 into fastify:main Mar 4, 2022
@github-actions
Copy link

github-actions bot commented Mar 5, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
test Issue or pr related to our testing infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants