New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow custom Context Config types for hooks' request
properties
#3786
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add tsd
tests?
Added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Just as a small note: Looks like I implemented the usecase for custom context in my PR as well (with also enabling custom Logger) check out: Do we have a plan on merge strategy or will you merge as soon as one of the PR's are approved (Which I guess should also be fine since changes should not be conflicting)? @sumbad @mcollina @RafaelGSS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
By now, hooks use default Context Config for the
request
property. This PR implies using a custom Context Config forrequest
in a hook if it was sent (repeats the same logic as forreply
).Checklist
npm run test
andnpm run benchmark
and the Code of conduct