Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: revert to using pull_request_target #3832

Merged
merged 2 commits into from Apr 13, 2022
Merged

ci: revert to using pull_request_target #3832

merged 2 commits into from Apr 13, 2022

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Apr 13, 2022

  • Fixes benchmark workflow failing to run
  • Fixes labeller workflow failing to run
  • permissions explicitly set in ci: reduce workflow permissions to minimum #3828 should negate security concerns of pull_request_target, as noted in the warning section in the GitHub Actions docs here
  • Removes Git credentials and auth token after checkout in the benchmark workflow's benchmark job, to further negate security concerns of pull_request_target; credentials aren't used for anything else after the checkout

Checklist

Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants