Support rc in version checks #3879
Conversation
| plugin[Symbol.for('plugin-meta')] = { | ||
| name: 'plugin', | ||
| fastify: '99.x' | ||
| } |
There was a problem hiding this comment.
I think this should specify fastify: '^98.0.0'.
There was a problem hiding this comment.
No this is expected and the current case.
There was a problem hiding this comment.
The idea here is that an RC Fastify allows plugins that require earlier versions of Fastify with ^fastify-version instead of >=fastify-version.
There was a problem hiding this comment.
I still don't understand, can you open a fresh issue if you think it's a bug?
| const sanitizedVersion = this.version.replace(/-rc.\d+$/, '') | ||
| if (requiredVersion && !semver.satisfies(sanitizedVersion, requiredVersion)) { |
There was a problem hiding this comment.
What about?:
const fastifyRc = /-rc.+$/.test(this.version)
if (requiredVersion && semver.satisfies(santizedVersion, requiredVersion, { includePrerelease: fastifyRc }) === false) {https://github.com/npm/node-semver/tree/c56a701f45653940ee8536eafe43b3e46c11d6cc#functions
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Checklist
npm run testandnpm run benchmarkand the Code of conduct