Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ecosystem): adding @eropple/fastify-openapi3 to community plugins #4067

Merged
merged 1 commit into from Jun 22, 2022

Conversation

eropple
Copy link
Contributor

@eropple eropple commented Jun 22, 2022

Hey there! I maintain @eropple/fastify-openapi3 and as I've brought it forward into Fastify v4 I figured it'd be a good time to let folks know about it.

Thanks for Fastify! It's awesome.

Checklist

@github-actions github-actions bot added documentation Improvements or additions to documentation plugin Identify a pr to the doc that adds a plugin. labels Jun 22, 2022
@eropple eropple changed the title Adding @eropple/fastify-openapi3 to Ecosystem.md docs(ecosystem): aadding @eropple/fastify-openapi3 to community plugins Jun 22, 2022
@eropple eropple changed the title docs(ecosystem): aadding @eropple/fastify-openapi3 to community plugins docs(ecosystem): adding @eropple/fastify-openapi3 to community plugins Jun 22, 2022
@mcollina
Copy link
Member

We are totally happy to list and include all alternative approaches in the ecosystem page, however I would like to ask if you could you amend your README avoiding language such as meh developer mouthfeel? Keep things on point like lack of effective type inference.

@eropple
Copy link
Contributor Author

eropple commented Jun 22, 2022

Hi - I've edited the README to be more anodyne. Thanks

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 34f9b17 into fastify:main Jun 22, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation plugin Identify a pr to the doc that adds a plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants