Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: explain common usage for injection into request instances #4084

Merged
merged 1 commit into from Jun 28, 2022

Conversation

Mazuh
Copy link
Contributor

@Mazuh Mazuh commented Jun 23, 2022

This is a very common practice that new users have to guess (specially on TypeScript is
not obvious how to do it at a first sight), so I'm improving the docs as suggested by @mcollina
and to meant to close fastify/help#551 on the help repo.

Checklist

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 23, 2022
@Eomm
Copy link
Member

Eomm commented Jun 25, 2022

Ci is failing due markdown linting, could you check it?

@Mazuh
Copy link
Contributor Author

Mazuh commented Jun 27, 2022

@Eomm I didn't know about .md constraints, sorry. I just fixed it and running ./node_modules/.bin/markdownlint-cli2 here locally now returns 0 (no errors). 🚀

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eomm Eomm merged commit 9ae9fc0 into fastify:main Jun 28, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How would one modify an incoming request
4 participants