Update Migration-Guide-V4.md #4091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
2 tasks
mcollina
reviewed
Jun 27, 2022
Eomm
reviewed
Jun 28, 2022
| better error reporting for route definition. As a result if you specify an `onRoute` hook | ||
| in a plugin you should either: | ||
| * wrap your routes in a plugin (recommended) | ||
| * use `await register(...)` |
There was a problem hiding this comment.
I would add the code example to let the user understand better the implications:
any onRoute hooks will not be executed when a plugin adds them if it is not awaited or the routes are wrapped in a plugin
There was a problem hiding this comment.
I added the code example used in the linked issue before and after refactoring. Could you have a look please if that was what you had in mind?
Co-authored-by: Matteo Collina <matteo.collina@gmail.com>
Add code examples to the Synchronous route definitions section
Eomm
approved these changes
Jun 28, 2022
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extending the V4 migration guide to highlight the changes to route definitions.
Resolves #4085
Checklist
and the Code of conduct