Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ecosystem linting #4097

Merged
merged 2 commits into from Jun 30, 2022
Merged

Add ecosystem linting #4097

merged 2 commits into from Jun 30, 2022

Conversation

jsumners
Copy link
Member

@jsumners jsumners commented Jun 30, 2022 •
edited

This PR adds a new workflow to lint the "Community" section of the ecosystem doc in order to verify that the items are in alphabetical order. We can see the result in this run -- https://github.com/fastify/fastify/runs/7123293753?check_suite_focus=true#step:3:11

Notice that there are some items in the doc that are currently out of order.

Checklist

@jsumners jsumners force-pushed the lint-ecosystem-doc branch 5 times, most recently from 8f6ef1e to ee9ab9e Compare June 30, 2022 01:21
@jsumners jsumners marked this pull request as ready for review June 30, 2022 01:21
mcollina
mcollina approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Does this means the script will fail right now? Could you put them in order?

@Eomm Eomm added the chore Small changes or internal project maintenance label Jun 30, 2022
@jsumners jsumners force-pushed the lint-ecosystem-doc branch 2 times, most recently from 8626388 to 400b3bd Compare June 30, 2022 11:24
@jsumners jsumners merged commit 42cf476 into main Jun 30, 2022
@jsumners jsumners deleted the lint-ecosystem-doc branch June 30, 2022 11:27
@jsumners
Copy link
Member Author

Does this means the script will fail right now? Could you put them in order?

Yes, that's what it would have meant. The doc has been updated.

@github-actions
Copy link

github-actions bot commented Jul 1, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcollina mcollina mcollina approved these changes

@Eomm Eomm Eomm approved these changes

Assignees
No one assigned
Labels
chore Small changes or internal project maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jsumners @mcollina @Eomm